-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files_for_e3sm
step for remapping rms tidal velocity
#770
Conversation
TestingI ran the I was able to generate the RMS tidal velocity: My version differs only slightly from @irenavankova's: The places where they differ are where there is very little overlap between the original grid and the MPAS mesh: |
@irenavankova, this is ready for you to try out and review. We should talk about the renormalization strategy. What I chose to do was to renormalize if there is more than 1% overlap and to set the velocity to zero if there is less. It seemed like you had a different approach to cells with less than 10% overlap where you always renormalized as if the overlap were 1%. I think my approach is a little more standard and should lead to smoother results but I don't think it matters much because only a handful of cells are affected. |
@irenavankova, I sent you an invitation to collaborate here. If you accept, I can add you as a reviewer but you can still comment without being an official reviewer. |
files_for_e3sm
step for remapping rms tidal velfiles_for_e3sm
step for remapping rms tidal velocity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works for me
@irenavankova, thanks for testing this out! |
This field is needed for any meshes that will run in the
TMIX
configuration described here:E3SM-Ocean-Discussion/E3SM#76
The field gets remapped from a dataset that @irenavankova has preprocessed from the CATS tidal model,
see https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/tidal_mixing/README.txt.
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes